Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v3.0.9 from future bundles published to NPM. #1634

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ronyeh
Copy link
Collaborator

@ronyeh ronyeh commented Aug 26, 2024

This fixes #1632

It addresses the confusion discussed in issue #1630

@ronyeh
Copy link
Collaborator Author

ronyeh commented Aug 26, 2024

After merging this PR, these URLs that serve the legacy 3.0.9 version of VexFlow will no longer work.

https://unpkg.com/vexflow4/releases/vexflow-debug.js

https://unpkg.com/vexflow4/releases/vexflow-min.js

@ronyeh ronyeh merged commit 103aad2 into 0xfe:master Aug 26, 2024
2 checks passed
@ronyeh
Copy link
Collaborator Author

ronyeh commented Aug 26, 2024

Released 4.2.6 which includes this PR.

This URL doesn't work, as expected:
https://unpkg.com/vexflow4@4.2.6/releases/vexflow-debug.js

These URLs which point to older NPM releases still work:
https://unpkg.com/vexflow4@4.2.5/releases/vexflow-debug.js

https://unpkg.com/vexflow@3.0.9/releases/vexflow-debug.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the 3.0.9 release from the 4.x NPM bundle
1 participant